github-actions[bot] commented on code in PR #26605:
URL: https://github.com/apache/doris/pull/26605#discussion_r1386579869
##########
be/src/runtime/load_stream.h:
##########
@@ -18,15 +18,14 @@
#pragma once
#include <gen_cpp/internal_service.pb.h>
Review Comment:
warning: 'gen_cpp/internal_service.pb.h' file not found
[clang-diagnostic-error]
```cpp
#include <gen_cpp/internal_service.pb.h>
^
```
##########
be/src/service/internal_service.cpp:
##########
@@ -337,13 +333,11 @@ void
PInternalServiceImpl::exec_plan_fragment_prepare(google::protobuf::RpcContr
}
}
-void
PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController*
controller,
+void
PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController*
/*controller*/,
Review Comment:
warning: method 'exec_plan_fragment_start' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController*
/*controller*/,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -556,13 +550,11 @@
}
}
-void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
controller,
+void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
/*controller*/,
Review Comment:
warning: method 'cancel_plan_fragment' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
/*controller*/,
```
##########
be/src/runtime/memory/jemalloc_hook.cpp:
##########
@@ -19,7 +19,6 @@
#include <stdint.h>
#include <stdlib.h>
-// IWYU pragma: no_include <opentelemetry/common/threadlocal.h>
#include "common/compiler_util.h" // IWYU pragma: keep
#include "jemalloc/jemalloc.h"
Review Comment:
warning: 'jemalloc/jemalloc.h' file not found [clang-diagnostic-error]
```cpp
#include "jemalloc/jemalloc.h"
^
```
##########
be/src/runtime/load_stream_mgr.h:
##########
@@ -18,15 +18,14 @@
#pragma once
#include <gen_cpp/internal_service.pb.h>
Review Comment:
warning: 'gen_cpp/internal_service.pb.h' file not found
[clang-diagnostic-error]
```cpp
#include <gen_cpp/internal_service.pb.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
