gavinchou commented on code in PR #26316:
URL: https://github.com/apache/doris/pull/26316#discussion_r1386150734
##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -1994,84 +2016,16 @@ private void setTableStateToNormal(Database db, boolean
committed, boolean isRep
}
public static RestoreJob read(DataInput in) throws IOException {
- RestoreJob job = new RestoreJob();
- job.readFields(in);
- return job;
- }
-
- @Override
- public void write(DataOutput out) throws IOException {
- super.write(out);
-
- Text.writeString(out, backupTimestamp);
- jobInfo.write(out);
- out.writeBoolean(allowLoad);
-
- Text.writeString(out, state.name());
-
- if (backupMeta != null) {
- out.writeBoolean(true);
- backupMeta.write(out);
- } else {
- out.writeBoolean(false);
- }
-
- fileMapping.write(out);
-
- out.writeLong(metaPreparedTime);
- out.writeLong(snapshotFinishedTime);
- out.writeLong(downloadFinishedTime);
-
- replicaAlloc.write(out);
-
- out.writeInt(restoredPartitions.size());
- for (Pair<String, Partition> entry : restoredPartitions) {
- Text.writeString(out, entry.first);
- entry.second.write(out);
- }
-
- out.writeInt(restoredTbls.size());
- for (Table tbl : restoredTbls) {
- tbl.write(out);
- }
-
- out.writeInt(restoredVersionInfo.rowKeySet().size());
- for (long tblId : restoredVersionInfo.rowKeySet()) {
- out.writeLong(tblId);
- out.writeInt(restoredVersionInfo.row(tblId).size());
- for (Map.Entry<Long, Long> entry :
restoredVersionInfo.row(tblId).entrySet()) {
- out.writeLong(entry.getKey());
- out.writeLong(entry.getValue());
- // It is version hash in the past,
- // but it useless but should compatible with old version so
that write 0 here
- out.writeLong(0L);
- }
- }
-
- out.writeInt(snapshotInfos.rowKeySet().size());
- for (long tabletId : snapshotInfos.rowKeySet()) {
- out.writeLong(tabletId);
- Map<Long, SnapshotInfo> map = snapshotInfos.row(tabletId);
- out.writeInt(map.size());
- for (Map.Entry<Long, SnapshotInfo> entry : map.entrySet()) {
- out.writeLong(entry.getKey());
- entry.getValue().write(out);
- }
- }
-
- out.writeInt(restoredResources.size());
- for (Resource resource : restoredResources) {
- resource.write(out);
- }
-
- // write properties
- out.writeInt(properties.size());
- for (Map.Entry<String, String> entry : properties.entrySet()) {
- Text.writeString(out, entry.getKey());
- Text.writeString(out, entry.getValue());
+ if (Env.getCurrentEnvJournalVersion() < FeMetaVersion.VERSION_127) {
+ RestoreJob job = new RestoreJob();
+ job.readFields(in);
+ return job;
}
+ String json = Text.readString(in);
+ return GsonUtils.GSON.fromJson(json, RestoreJob.class);
Review Comment:
Is `write()` missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
