mymeiyi commented on code in PR #26075:
URL: https://github.com/apache/doris/pull/26075#discussion_r1386119613
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java:
##########
@@ -152,7 +163,15 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
}
OlapTableSink sink = ((OlapTableSink)
planner.getFragments().get(0).getSink());
-
+ if (ctx.getSessionVariable().enableInsertGroupCommit) {
+ // group commit
+ if (!analyzeGroupCommit(sink, physicalOlapTableSink)) {
Review Comment:
Non group commit insert shoud also execute successfully in Nereids, so the
`AnalysisException` should not be thrown?
```
if (analyzeGroupCommit(sink, physicalOlapTableSink)) {
handleGroupCommit(ctx, sink, physicalOlapTableSink);
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
