This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 70bc8600a9e [fix](regression) fix regression framework bug: if real
test result is negative, it will miss check test result (#25734)
70bc8600a9e is described below
commit 70bc8600a9e76e53b258dd08611309e4a04cfa6f
Author: TengJianPing <18241664+jackte...@users.noreply.github.com>
AuthorDate: Wed Nov 8 09:05:58 2023 +0800
[fix](regression) fix regression framework bug: if real test result is
negative, it will miss check test result (#25734)
---
be/src/vec/functions/function_binary_arithmetic.h | 3 ++-
.../decimalv3/test_agg_keys_schema_change_decimalv3.out | 2 +-
.../main/groovy/org/apache/doris/regression/util/OutputUtils.groovy | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/functions/function_binary_arithmetic.h
b/be/src/vec/functions/function_binary_arithmetic.h
index 7198a08bb22..911704718fb 100644
--- a/be/src/vec/functions/function_binary_arithmetic.h
+++ b/be/src/vec/functions/function_binary_arithmetic.h
@@ -79,7 +79,8 @@ struct OperationTraits {
std::is_same_v<Op, DivideIntegralImpl<T, T>>;
static constexpr bool can_overflow =
(is_plus_minus || is_multiply) &&
- (IsDecimalV2<OpA> || IsDecimalV2<OpB> || IsDecimal256<OpA> ||
IsDecimal256<OpB>);
+ (IsDecimalV2<OpA> || IsDecimalV2<OpB> || IsDecimal128I<OpA> ||
IsDecimal128I<OpB> ||
+ IsDecimal256<OpA> || IsDecimal256<OpB>);
static constexpr bool has_variadic_argument =
!std::is_void_v<decltype(has_variadic_argument_types(std::declval<Op>()))>;
};
diff --git
a/regression-test/data/schema_change_p0/decimalv3/test_agg_keys_schema_change_decimalv3.out
b/regression-test/data/schema_change_p0/decimalv3/test_agg_keys_schema_change_decimalv3.out
index 1b9f52fd5ea..fc5d8e286ce 100644
---
a/regression-test/data/schema_change_p0/decimalv3/test_agg_keys_schema_change_decimalv3.out
+++
b/regression-test/data/schema_change_p0/decimalv3/test_agg_keys_schema_change_decimalv3.out
@@ -18,7 +18,7 @@
0.11111111111111111111111111111111100000
11111111111111111111111111111.1100000000
0.11111111111111111111111111111111100000
11111111111111111111111111111.110
-- !sql --
-0.11111111111111111111111111111111100000 9223372036854775.807
0.11111111111111111111111111111111100000
11111111111111111111111111111.110
+0.11111111111111111111111111111111100000 -999999999999999.999
0.11111111111111111111111111111111100000
11111111111111111111111111111.110
-- !sql --
0.11111111111111111111111111111111100000 -9223.372036854775808
0.11111111111111111111111111111111100000
11111111111111111111111111111.110
diff --git
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy
index 757a4a593f8..b140673e7a7 100644
---
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy
+++
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy
@@ -76,7 +76,7 @@ class OutputUtils {
double expectDouble = Double.parseDouble(expectCell)
double realDouble = Double.parseDouble(realCell)
- double realRelativeError = Math.abs(expectDouble - realDouble)
/ realDouble
+ double realRelativeError = Math.abs(expectDouble - realDouble)
/ Math.abs(realDouble)
double expectRelativeError = 1e-8
if (expectRelativeError < realRelativeError) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
