github-actions[bot] commented on code in PR #26537:
URL: https://github.com/apache/doris/pull/26537#discussion_r1384810288
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -454,11 +484,11 @@ Status
BetaRowsetWriter::flush_memtable(vectorized::Block* block, int32_t segmen
return Status::OK();
}
-Status BetaRowsetWriter::flush_single_block(const vectorized::Block* block) {
+Status BaseBetaRowsetWriter::flush_single_block(const vectorized::Block*
block) {
return _segment_creator.flush_single_block(block);
}
-Status BetaRowsetWriter::wait_flying_segcompaction() {
+Status BetaRowsetWriter::_wait_flying_segcompaction() {
Review Comment:
warning: method '_wait_flying_segcompaction' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:200:
```diff
- Status _wait_flying_segcompaction();
+ static Status _wait_flying_segcompaction();
```
##########
be/src/olap/delta_writer.h:
##########
@@ -20,7 +20,6 @@
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/olap/delta_writer.cpp:
##########
@@ -140,37 +146,31 @@ Status DeltaWriter::close() {
return _memtable_writer->close();
}
-Status DeltaWriter::build_rowset() {
+Status BaseDeltaWriter::build_rowset() {
std::lock_guard<std::mutex> l(_lock);
DCHECK(_is_init)
<< "delta writer is supposed be to initialized before
build_rowset() being called";
SCOPED_TIMER(_close_wait_timer);
RETURN_IF_ERROR(_memtable_writer->close_wait(_profile));
- return _rowset_builder.build_rowset();
+ return _rowset_builder->build_rowset();
}
-Status DeltaWriter::submit_calc_delete_bitmap_task() {
- return _rowset_builder.submit_calc_delete_bitmap_task();
+Status BaseDeltaWriter::submit_calc_delete_bitmap_task() {
+ return _rowset_builder->submit_calc_delete_bitmap_task();
}
-Status DeltaWriter::wait_calc_delete_bitmap() {
- return _rowset_builder.wait_calc_delete_bitmap();
+Status BaseDeltaWriter::wait_calc_delete_bitmap() {
+ return _rowset_builder->wait_calc_delete_bitmap();
}
-Status DeltaWriter::commit_txn(const PSlaveTabletNodes& slave_tablet_nodes,
- const bool write_single_replica) {
- if (config::cloud_mode) {
- return Status::OK();
- }
+Status DeltaWriter::commit_txn(const PSlaveTabletNodes& slave_tablet_nodes) {
Review Comment:
warning: method 'commit_txn' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DeltaWriter::commit_txn(const PSlaveTabletNodes&
slave_tablet_nodes) {
```
##########
be/src/olap/rowset/beta_rowset_writer.h:
##########
@@ -19,8 +19,6 @@
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -644,7 +660,8 @@
return Status::OK();
}
-Status BetaRowsetWriter::create_file_writer(uint32_t segment_id,
io::FileWriterPtr& file_writer) {
+Status BaseBetaRowsetWriter::create_file_writer(uint32_t segment_id,
Review Comment:
warning: method 'create_file_writer' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status BaseBetaRowsetWriter::create_file_writer(uint32_t segment_id,
```
##########
be/src/olap/rowset_builder.cpp:
##########
@@ -259,14 +243,14 @@ Status RowsetBuilder::submit_calc_delete_bitmap_task() {
return Status::OK();
}
- LOG(INFO) << "submit calc delete bitmap task to executor, tablet_id: " <<
tablet->tablet_id()
+ LOG(INFO) << "submit calc delete bitmap task to executor, tablet_id: " <<
tablet()->tablet_id()
<< ", txn_id: " << _req.txn_id;
- return tablet->commit_phase_update_delete_bitmap(_rowset, _rowset_ids,
_delete_bitmap, segments,
- _req.txn_id,
_calc_delete_bitmap_token.get(),
- nullptr);
+ return tablet()->commit_phase_update_delete_bitmap(_rowset, _rowset_ids,
_delete_bitmap,
+ segments, _req.txn_id,
+
_calc_delete_bitmap_token.get(), nullptr);
}
-Status RowsetBuilder::wait_calc_delete_bitmap() {
+Status BaseRowsetBuilder::wait_calc_delete_bitmap() {
Review Comment:
warning: method 'wait_calc_delete_bitmap' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset_builder.h:64:
```diff
- Status wait_calc_delete_bitmap();
+ static Status wait_calc_delete_bitmap();
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -17,7 +17,6 @@
#pragma once
-#include <gen_cpp/internal_service.pb.h>
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
##########
be/src/olap/rowset_builder.cpp:
##########
@@ -331,9 +309,9 @@
return Status::OK();
}
-void RowsetBuilder::_build_current_tablet_schema(int64_t index_id,
- const OlapTableSchemaParam*
table_schema_param,
- const TabletSchema&
ori_tablet_schema) {
+void BaseRowsetBuilder::_build_current_tablet_schema(int64_t index_id,
Review Comment:
warning: method '_build_current_tablet_schema' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset_builder.h:86:
```diff
- void _build_current_tablet_schema(int64_t index_id,
+ static void _build_current_tablet_schema(int64_t index_id,
```
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -621,7 +637,7 @@
return rowset;
}
-Status BetaRowsetWriter::_create_file_writer(std::string path,
io::FileWriterPtr& file_writer) {
+Status BaseBetaRowsetWriter::_create_file_writer(std::string path,
io::FileWriterPtr& file_writer) {
Review Comment:
warning: method '_create_file_writer' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status BaseBetaRowsetWriter::_create_file_writer(std::string path,
io::FileWriterPtr& file_writer) {
```
##########
be/src/runtime/load_stream_writer.h:
##########
@@ -32,16 +27,12 @@
#include "brpc/stream.h"
Review Comment:
warning: 'brpc/stream.h' file not found [clang-diagnostic-error]
```cpp
#include "brpc/stream.h"
^
```
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -67,21 +67,41 @@ TabletsChannel::TabletsChannel(const TabletsChannelKey&
key, const UniqueId& loa
});
}
-TabletsChannel::~TabletsChannel() {
+TabletsChannel::TabletsChannel(StorageEngine& engine, const TabletsChannelKey&
key,
+ const UniqueId& load_id, bool is_high_priority,
+ RuntimeProfile* profile)
+ : BaseTabletsChannel(key, load_id, is_high_priority, profile),
_engine(engine) {}
+
+BaseTabletsChannel::~BaseTabletsChannel() {
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
BaseTabletsChannel::~BaseTabletsChannel() {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
