yiguolei commented on code in PR #26475:
URL: https://github.com/apache/doris/pull/26475#discussion_r1384751212
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeArithmetic.java:
##########
@@ -37,315 +38,543 @@ public class DateTimeArithmetic {
* datetime arithmetic function date-add.
*/
@ExecFunction(name = "date_add", argTypes = {"DATE", "INT"}, returnType =
"DATE")
- public static Expression dateAdd(DateLiteral date, IntegerLiteral day) {
- return daysAdd(date, day);
+ public static Expression dateAdd(DateLiteral date, IntegerLiteral day)
throws Exception {
+ Expression res = daysAdd(date, day);
+ if (res instanceof NullLiteral) {
Review Comment:
remove these code, we should not depend on nullable to check if the value is
out of range
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
