shuke987 commented on code in PR #26506:
URL: https://github.com/apache/doris/pull/26506#discussion_r1384711957


##########
regression-test/plugins/plugins_create_table_nested_type.groovy:
##########
@@ -18,75 +18,125 @@
 import org.apache.doris.regression.suite.Suite
 
 // create table with nested data type, now default complex data include array, 
map, struct
-Suite.metaClass.create_table_with_nested_type = { int maxDepth, String tbName 
/* param */ ->
+Suite.metaClass.create_table_with_nested_type = { int maxDepth, def typeArr, 
String tbName /* param */ ->
     Suite suite = delegate as Suite
 
+    if (typeArr.size() != maxDepth) {
+        println("level not equal typeArr")
+        return
+    }
+    def cur_depth = typeArr.size()
     maxDepth = maxDepth > 9 ? 9 : maxDepth
+    maxDepth = maxDepth < 1 ? 1 : maxDepth
 
+//        def dataTypeArr = ["boolean", "tinyint(4)", "smallint(6)", 
"int(11)", "bigint(20)", "largeint(40)", "float",
+//                           "double", "decimal(20, 3)", "decimalv3(20, 3)", 
"date", "datetime", "datev2", "datetimev2(0)",
+//                           "char(15)", "varchar(100)", "text", 
"hll","bitmap", "QUANTILE_STATE"]
     def dataTypeArr = ["boolean", "tinyint(4)", "smallint(6)", "int(11)", 
"bigint(20)", "largeint(40)", "float",
                        "double", "decimal(20, 3)", "decimalv3(20, 3)", "date", 
"datetime", "datev2", "datetimev2(0)",
                        "char(15)", "varchar(100)", "text"]
     def colNameArr = ["c_bool", "c_tinyint", "c_smallint", "c_int", 
"c_bigint", "c_largeint", "c_float",
                       "c_double", "c_decimal", "c_decimalv3", "c_date", 
"c_datetime", "c_datev2", "c_datetimev2",
                       "c_char", "c_varchar", "c_string"]
     def complexDataTypeArr = ["array", "map", "struct"]
-//    def tbName = "test"
+    def baseStructScala = 
"col1:int(11),col2:tinyint(4),col3:smallint(6),col4:boolean,col5:bigint(20),col6:largeint(40),"
 +

Review Comment:
   use cross-line string 



##########
regression-test/plugins/plugins_create_table_nested_type.groovy:
##########
@@ -18,75 +18,125 @@
 import org.apache.doris.regression.suite.Suite
 
 // create table with nested data type, now default complex data include array, 
map, struct
-Suite.metaClass.create_table_with_nested_type = { int maxDepth, String tbName 
/* param */ ->
+Suite.metaClass.create_table_with_nested_type = { int maxDepth, def typeArr, 
String tbName /* param */ ->
     Suite suite = delegate as Suite
 
+    if (typeArr.size() != maxDepth) {
+        println("level not equal typeArr")
+        return

Review Comment:
   throw exception?



##########
regression-test/plugins/plugins_create_table_nested_type.groovy:
##########
@@ -18,75 +18,125 @@
 import org.apache.doris.regression.suite.Suite
 
 // create table with nested data type, now default complex data include array, 
map, struct
-Suite.metaClass.create_table_with_nested_type = { int maxDepth, String tbName 
/* param */ ->
+Suite.metaClass.create_table_with_nested_type = { int maxDepth, def typeArr, 
String tbName /* param */ ->
     Suite suite = delegate as Suite
 
+    if (typeArr.size() != maxDepth) {
+        println("level not equal typeArr")
+        return

Review Comment:
   throw exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to