yiguolei commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1384438186
##########
be/src/vec/columns/column_string.h:
##########
@@ -478,6 +491,8 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
ColumnPtr filter(const Filter& filt, ssize_t result_size_hint) const
override;
size_t filter(const Filter& filter) override;
+ Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn*
col_ptr) override;
Review Comment:
这个方法，没有任何地方引用过吧？
##########
be/src/vec/columns/column_string.h:
##########
@@ -478,6 +491,8 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
ColumnPtr filter(const Filter& filt, ssize_t result_size_hint) const
override;
size_t filter(const Filter& filter) override;
+ Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn*
col_ptr) override;
Review Comment:
这个方法，没有任何地方引用过吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
