morrySnow commented on code in PR #26308:
URL: https://github.com/apache/doris/pull/26308#discussion_r1384288008
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##########
@@ -2155,7 +2156,8 @@ public Type getCompatibleType(Type lastCompatibleType,
Expr lastCompatibleExpr,
if (lastCompatibleType == null) {
newCompatibleType = expr.getType();
} else {
- newCompatibleType =
Type.getAssignmentCompatibleType(lastCompatibleType, expr.getType(), false);
+ newCompatibleType = Type.getAssignmentCompatibleType(
Review Comment:
why not check enableDecimal256() in getAssignmentCompatibleType rather than
add a new parameter?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java:
##########
@@ -111,7 +111,7 @@ public static void initBuiltins(FunctionSet functionSet) {
for (int j = 0; j < Type.getNumericTypes().size(); j++) {
Type t2 = Type.getNumericTypes().get(j);
- Type retType =
Type.getNextNumType(Type.getAssignmentCompatibleType(t1, t2, false));
+ Type retType =
Type.getNextNumType(Type.getAssignmentCompatibleType(t1, t2, false, false));
Review Comment:
why here need to disable decimal256 explicitly? add some comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
