deardeng commented on code in PR #26412: URL: https://github.com/apache/doris/pull/26412#discussion_r1384338725
########## fe/fe-core/src/main/java/org/apache/doris/clone/Rebalancer.java: ########## @@ -77,6 +86,31 @@ public List<TabletSchedCtx> selectAlternativeTablets() { protected abstract List<TabletSchedCtx> selectAlternativeTabletsForCluster( LoadStatisticForTag clusterStat, TStorageMedium medium); + protected boolean isNeedBalanced(LoadStatisticForTag clusterStat, TStorageMedium medium, + List<Long> fromBes, List<Long> toBes) { + return true; + } + + protected boolean unPickOverLongTime(LoadStatisticForTag clusterStat, TStorageMedium medium) { + if (lastPickTimeTable.containsRow(clusterStat)) { + Map<TStorageMedium, Long> mediumLastPickTimeMap = lastPickTimeTable.row(clusterStat); + if (mediumLastPickTimeMap.containsKey(medium)) { + Long lastPickTimeTable = mediumLastPickTimeMap.get(medium); + return lastPickTimeTable > 0 && System.currentTimeMillis() > lastPickTimeTable + 10 * 60 * 1000L; + } else { + return false; + } + } else { + return false; + } + } + + protected void removeFromLastPickTimeTable(Tag tag, TStorageMedium medium) { Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org