gavinchou commented on code in PR #26483:
URL: https://github.com/apache/doris/pull/26483#discussion_r1383647225
##########
be/src/olap/wal_writer.cpp:
##########
@@ -44,6 +47,10 @@ Status WalWriter::finalize() {
}
Status WalWriter::append_blocks(const PBlockArray& blocks) {
+ std::unique_lock l(_mutex);
Review Comment:
Will `append_blocks()` be called concurrently?
It seems not.
If yes, the original impl. is buggy?
And, we should not lock a mutex before issuing any IO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
