deardeng commented on code in PR #26428: URL: https://github.com/apache/doris/pull/26428#discussion_r1382944155
########## regression-test/suites/schema_change/test_schema_change_concurrent_with_txn.groovy: ########## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +import org.apache.doris.regression.suite.ClusterOptions +import org.apache.doris.regression.util.NodeType + +suite('test_schema_change_concurrent_with_txn') { + def options = new ClusterOptions() + options.enableDebugPoints() + options.feConfigs.add('publish_wait_time_second=-1') + docker(options) { + sql 'SET GLOBAL insert_visible_timeout_ms = 2000' + + def result = sql 'SELECT DATABASE()' + def dbName = result[0][0] + + sql 'CREATE TABLE tbl_1 (k1 INT, k2 INT) PROPERTIES ( "light_schema_change" = "false")' + sql 'INSERT INTO tbl_1 VALUES (1, 10)' + sql 'INSERT INTO tbl_1 VALUES (2, 20)' + order_qt_select_1_1 'SELECT * FROM tbl_1' + + sql 'CREATE TABLE tbl_2 AS SELECT * FROM tbl_1' + order_qt_select_2_1 'SELECT * FROM tbl_1' Review Comment: tbl_2 ########## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ########## @@ -1111,8 +1114,28 @@ public void finishTransaction(long transactionId) throws UserException { LOG.info("finish transaction {} successfully, publish result: {}", transactionState, publishResult.name()); } - private void checkReplicaContinuousVersionSucc(long tabletId, Replica replica, long version, - PublishVersionTask backendPublishTask, Set<Long> errorReplicaIds, List<Replica> tabletSuccReplicas, + private boolean isCheckTxnIgnoreAlterReplica(long transactionId, OlapTable table) { Review Comment: function name publishSkipAlterReplica ？ ########## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ########## @@ -1111,8 +1114,28 @@ public void finishTransaction(long transactionId) throws UserException { LOG.info("finish transaction {} successfully, publish result: {}", transactionState, publishResult.name()); } - private void checkReplicaContinuousVersionSucc(long tabletId, Replica replica, long version, - PublishVersionTask backendPublishTask, Set<Long> errorReplicaIds, List<Replica> tabletSuccReplicas, + private boolean isCheckTxnIgnoreAlterReplica(long transactionId, OlapTable table) { Review Comment: function name publishSkipAlterReplica ？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
