github-actions[bot] commented on code in PR #26425:
URL: https://github.com/apache/doris/pull/26425#discussion_r1382504806
##########
be/test/io/fs/s3_file_writer_test.cpp:
##########
@@ -73,13 +76,23 @@ class S3FileWriterTest : public testing::Test {
}
static void TearDownTestSuite() {
+ if (getenv(RUN_S3_TESTS) == nullptr || std::string
{getenv(RUN_S3_TESTS)} != "true") {
+ GTEST_SKIP();
+ }
ExecEnv::GetInstance()->_s3_file_upload_thread_pool->shutdown();
ExecEnv::GetInstance()->_s3_file_upload_thread_pool = nullptr;
delete ExecEnv::GetInstance()->_s3_buffer_pool;
ExecEnv::GetInstance()->_s3_buffer_pool = nullptr;
}
+ void SetUp() override {
Review Comment:
warning: method 'SetUp' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void SetUp() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
