zhannngchen commented on code in PR #24788: URL: https://github.com/apache/doris/pull/24788#discussion_r1381269226
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -1212,6 +1213,12 @@ Status SegmentIterator::_lookup_ordinal_from_pk_index(const RowCursor& key, bool // The sequence column needs to be removed from primary key index when comparing key bool has_seq_col = _segment->_tablet_schema->has_sequence_col(); + bool has_rowid = !_segment->_tablet_schema->cluster_key_idxes().empty(); Review Comment: Is it possiable to add a new page type for IndexedColumnWriter that can write key:value into it, using the rowid as value. In this case, we don't need to process logics of rowid here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org