morrySnow commented on code in PR #26163:
URL: https://github.com/apache/doris/pull/26163#discussion_r1381217816
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java:
##########
@@ -113,7 +113,7 @@ protected boolean skip(TableIf table) {
if (!(table instanceof OlapTable || table instanceof ExternalTable)) {
return true;
}
- if (table.getDataSize(true) <
Config.huge_table_lower_bound_size_in_bytes) {
+ if (table.getDataSize(true) <
Config.huge_table_lower_bound_size_in_bytes * 5) {
Review Comment:
what's mean about `5`?
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisTaskExecutor.java:
##########
@@ -72,18 +72,22 @@ private void cancelExpiredTask() {
private void doCancelExpiredJob() {
for (;;) {
+ tryToCancel();
+ }
+ }
+
+ protected void tryToCancel() {
+ try {
+ AnalysisTaskWrapper taskWrapper = taskQueue.take();
try {
- AnalysisTaskWrapper taskWrapper = taskQueue.take();
- try {
- long timeout =
TimeUnit.HOURS.toMillis(Config.analyze_task_timeout_in_hours)
- - (System.currentTimeMillis() -
taskWrapper.getStartTime());
- taskWrapper.get(timeout < 0 ? 0 : timeout,
TimeUnit.MILLISECONDS);
- } catch (Exception e) {
- taskWrapper.cancel(e.getMessage());
- }
- } catch (Throwable throwable) {
- LOG.warn(throwable);
+ long timeout =
TimeUnit.HOURS.toMillis(Config.analyze_task_timeout_in_hours)
+ - (System.currentTimeMillis() -
taskWrapper.getStartTime());
+ taskWrapper.get(timeout < 0 ? 0 : timeout,
TimeUnit.MILLISECONDS);
+ } catch (Exception e) {
+ taskWrapper.cancel(e.getMessage());
}
+ } catch (Throwable throwable) {
+ LOG.warn(throwable);
Review Comment:
add warning msg prefix, such as `cancel analysis task failed, ...`, log
exception stack too
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1257,6 +1259,10 @@ public void setMaxJoinNumberOfReorder(int
maxJoinNumberOfReorder) {
"the runtime filter id in IGNORE_RUNTIME_FILTER_IDS list
will not be generated"})
public String ignoreRuntimeFilterIds = "";
+
+ @VariableMgr.VarAttr(name = INSERT_MERGE_ITEM_COUNT, flag =
VariableMgr.GLOBAL)
+ public int insertMergeItemCount = 200;
Review Comment:
加上描述，名字要起一个和统计信息相关的
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1257,6 +1259,10 @@ public void setMaxJoinNumberOfReorder(int
maxJoinNumberOfReorder) {
"the runtime filter id in IGNORE_RUNTIME_FILTER_IDS list
will not be generated"})
public String ignoreRuntimeFilterIds = "";
+
+ @VariableMgr.VarAttr(name = INSERT_MERGE_ITEM_COUNT, flag =
VariableMgr.GLOBAL)
+ public int insertMergeItemCount = 200;
Review Comment:
加上描述，名字要起一个和统计信息相关的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
