github-actions[bot] commented on code in PR #26357:
URL: https://github.com/apache/doris/pull/26357#discussion_r1381123649
##########
be/src/runtime/load_stream_writer.cpp:
##########
@@ -121,7 +121,16 @@ Status LoadStreamWriter::close_segment(uint32_t segid) {
return Status::OK();
}
-Status LoadStreamWriter::add_segment(uint32_t segid, SegmentStatistics& stat) {
+Status LoadStreamWriter::add_segment(uint32_t segid, const SegmentStatistics&
stat) {
Review Comment:
warning: method 'add_segment' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/load_stream_writer.h:73:
```diff
- Status add_segment(uint32_t segid, const SegmentStatistics& stat);
+ static Status add_segment(uint32_t segid, const SegmentStatistics&
stat);
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@ TEST_F(LoadStreamStubPoolTest, test) {
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
Review Comment:
warning: 101 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
+ auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
+ auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
Review Comment:
warning: 101 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams3 = pool.get_or_create(load_id, src_id, 101, 5);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
+ auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
Review Comment:
warning: 102 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams2 = pool.get_or_create(load_id, src_id, 102, 5);
^
```
##########
be/test/vec/exec/load_stream_stub_pool_test.cpp:
##########
@@ -36,9 +36,9 @@
PUniqueId load_id;
load_id.set_hi(1);
load_id.set_hi(2);
- auto streams1 = pool.get_or_create(load_id, src_id, 101);
- auto streams2 = pool.get_or_create(load_id, src_id, 102);
- auto streams3 = pool.get_or_create(load_id, src_id, 101);
+ auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
Review Comment:
warning: 5 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
auto streams1 = pool.get_or_create(load_id, src_id, 101, 5);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
