xinyiZzz commented on code in PR #25919: URL: https://github.com/apache/doris/pull/25919#discussion_r1379487020
########## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ########## @@ -17,6 +17,7 @@ package org.apache.doris.qe; Review Comment: 感觉没必要，ConnectContext 绝大部分代码 Flight Sql 都能复用，区别基本只在于 mysqlChannel 和 flightSqlChannel ########## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ########## @@ -17,6 +17,7 @@ package org.apache.doris.qe; Review Comment: 感觉没必要，ConnectContext 绝大部分代码 Flight Sql 都能复用，区别基本只在于 mysqlChannel 和 flightSqlChannel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
