github-actions[bot] commented on code in PR #26248:
URL: https://github.com/apache/doris/pull/26248#discussion_r1378825024
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -292,21 +295,30 @@ class JoinHashMapTable : public HashMapTable<Key, Cell,
Hash, Grower, Allocator>
}
private:
+ template <bool with_other_conjuncts>
auto _find_batch_right_semi_anti(const Key* __restrict keys,
const uint32_t* __restrict bucket_nums,
int probe_idx,
- int probe_rows) {
+ int probe_rows, uint32_t* __restrict
probe_idxs,
+ uint32_t* __restrict build_idxs) {
+ auto matched_cnt = 0;
while (probe_idx < probe_rows) {
auto build_idx = first[bucket_nums[probe_idx]];
while (build_idx) {
if (keys[probe_idx] == build_keys[build_idx]) {
- visited[build_idx] = 1;
+ if constexpr (with_other_conjuncts) {
+ build_idxs[matched_cnt] = build_idx;
+ probe_idxs[matched_cnt] = probe_idx;
+ matched_cnt++;
+ } else {
+ visited[build_idx] = 1;
+ }
}
build_idx = next[build_idx];
}
probe_idx++;
}
- return std::tuple {probe_idx, 0u, 0};
+ return std::tuple {probe_idx, 0u, matched_cnt};
Review Comment:
warning: integer literal has suffix 'u', which is not uppercase
[readability-uppercase-literal-suffix]
```suggestion
return std::tuple {probe_idx, 0U, matched_cnt};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
