yiguolei commented on code in PR #26174: URL: https://github.com/apache/doris/pull/26174#discussion_r1378322276
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java: ########## @@ -103,7 +103,12 @@ private WorkloadGroup(long id, String name, Map<String, String> properties, long properties.put(ENABLE_MEMORY_OVERCOMMIT, properties.get(ENABLE_MEMORY_OVERCOMMIT).toLowerCase()); } if (properties.containsKey(CPU_HARD_LIMIT)) { - this.cpuHardLimit = Integer.parseInt(properties.get(CPU_HARD_LIMIT)); + String cpuHardLimitStr = properties.get(CPU_HARD_LIMIT); Review Comment: if user write code like cpu_hard_limit="1% ", then the code is wrong. I think you should trim -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org