zhiqiang-hhhh commented on code in PR #26149:
URL: https://github.com/apache/doris/pull/26149#discussion_r1377058380
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/MysqlLoadManager.java:
##########
@@ -193,18 +193,19 @@ public LoadJobRowResult
executeMySqlLoadJobFromStmt(ConnectContext context, Data
String errorUrl =
Optional.ofNullable(result.get("ErrorURL"))
.map(JsonElement::getAsString).orElse("");
failedRecords.offer(new MySqlLoadFailRecord(loadId,
errorUrl));
- LOG.warn("Execute mysql data load failed with request:
{} and response: {}", request, body);
+ LOG.warn("Execute mysql load failed with request: {}
and response: {}, job id: {}",
+ request, body, loadId);
throw new
LoadException(result.get("Message").getAsString() + " with load id " + loadId);
}
loadResult.incRecords(result.get("NumberLoadedRows").getAsLong());
loadResult.incSkipped(result.get("NumberFilteredRows").getAsInt());
}
}
} catch (Throwable t) {
- LOG.warn("Execute mysql load {} failed", loadId, t);
+ LOG.warn("Execute mysql load {} failed, msg: {}", loadId,
t.getMessage());
Review Comment:
done
> 异常的时候，不要打印t.getMessage, 要直接输出t，这样会有error stack，包括级联的error stack
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/MysqlLoadManager.java:
##########
@@ -193,18 +193,19 @@ public LoadJobRowResult
executeMySqlLoadJobFromStmt(ConnectContext context, Data
String errorUrl =
Optional.ofNullable(result.get("ErrorURL"))
.map(JsonElement::getAsString).orElse("");
failedRecords.offer(new MySqlLoadFailRecord(loadId,
errorUrl));
- LOG.warn("Execute mysql data load failed with request:
{} and response: {}", request, body);
+ LOG.warn("Execute mysql load failed with request: {}
and response: {}, job id: {}",
+ request, body, loadId);
throw new
LoadException(result.get("Message").getAsString() + " with load id " + loadId);
}
loadResult.incRecords(result.get("NumberLoadedRows").getAsLong());
loadResult.incSkipped(result.get("NumberFilteredRows").getAsInt());
}
}
} catch (Throwable t) {
- LOG.warn("Execute mysql load {} failed", loadId, t);
+ LOG.warn("Execute mysql load {} failed, msg: {}", loadId,
t.getMessage());
Review Comment:
done
> 异常的时候，不要打印t.getMessage, 要直接输出t，这样会有error stack，包括级联的error stack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
