starocean999 commented on code in PR #25966:
URL: https://github.com/apache/doris/pull/25966#discussion_r1377054573
##########
fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java:
##########
@@ -231,21 +231,21 @@ public static IntLiteral unixTimestamp2(LiteralExpr arg)
throws AnalysisExceptio
return new IntLiteral(unixTime, Type.INT);
}
- @FEFunction(name = "from_unixtime", argTypes = { "INT" }, returnType =
"VARCHAR")
+ @FEFunction(name = "from_unixtime", argTypes = { "BIGINT" }, returnType =
"VARCHAR")
public static StringLiteral fromUnixTime(LiteralExpr unixTime) throws
AnalysisException {
// if unixTime < 0, we should return null, throw a exception and let
BE process
- if (unixTime.getLongValue() < 0 || unixTime.getLongValue() >=
Integer.MAX_VALUE) {
+ if (unixTime.getLongValue() < 0 || unixTime.getLongValue() >
32536771199L) {
Review Comment:
pls add some comment about the magic number 32536771199L. And do same in
nereids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
