morrySnow commented on code in PR #25715:
URL: https://github.com/apache/doris/pull/25715#discussion_r1377028733
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/PatternDescriptor.java:
##########
@@ -63,6 +66,22 @@ public <OUTPUT_TYPE extends Plan> PatternMatcher<INPUT_TYPE,
OUTPUT_TYPE> thenAp
return new PatternMatcher<>(pattern, defaultPromise, matchedAction);
}
+ /**
+ * Same as thenApply, but catch all exception and return null
+ */
+ public <OUTPUT_TYPE extends Plan> PatternMatcher<INPUT_TYPE, OUTPUT_TYPE>
thenApplyNoThrow(
+ MatchedAction<INPUT_TYPE, OUTPUT_TYPE> matchedAction) {
+ MatchedAction<INPUT_TYPE, OUTPUT_TYPE> adaptMatchedAction = ctx -> {
+ try {
+ return matchedAction.apply(ctx);
+ } catch (Exception ex) {
+ LOG.warn(ex.getMessage());
Review Comment:
add some msg header for easy search and log exception stack for easy debug
```suggestion
LOG.warn("nereids apply rule failed, because {}",
ex.getMessage(), ex);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
