JackDrogon commented on code in PR #26013:
URL: https://github.com/apache/doris/pull/26013#discussion_r1375632247
##########
be/src/util/doris_metrics.cpp:
##########
@@ -341,59 +341,55 @@ void DorisMetrics::_update() {
}
// get num of thread of doris_be process
-// from /proc/pid/task
+// from /proc/self/task
void DorisMetrics::_update_process_thread_num() {
- int64_t pid = getpid();
- std::stringstream ss;
ss << "/proc/" << pid << "/task/";
- int64_t count = 0;
- auto cb = [&count](const io::FileInfo& file) -> bool {
- count += 1;
- return true;
- };
- Status st = io::global_local_filesystem()->iterate_directory(ss.str(), cb);
- if (!st.ok()) {
- LOG(WARNING) << "failed to count thread num: " << st;
- process_thread_num->set_value(0);
+ std::error_code ec;
+ std::filesystem::directory_iterator dict_iter("/proc/self/task/", ec);
+ if (ec) {
+ LOG(WARNING) << "failed to count thread num: " << ec.message();
+ process_fd_num_used->set_value(0);
return;
}
+ int64_t count = std::count_if(dict_iter, fs::directory_iterator(),
+ [](const fs::directory_entry& entry) {
Review Comment:
in lambda , use `const auto & entry` to replace `const fs::directory_entry&
entry`
##########
be/src/util/doris_metrics.cpp:
##########
@@ -341,59 +341,55 @@ void DorisMetrics::_update() {
}
// get num of thread of doris_be process
-// from /proc/pid/task
+// from /proc/self/task
void DorisMetrics::_update_process_thread_num() {
- int64_t pid = getpid();
- std::stringstream ss;
ss << "/proc/" << pid << "/task/";
Review Comment:
remove this dead code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
