zddr commented on code in PR #26082:
URL: https://github.com/apache/doris/pull/26082#discussion_r1375621595


##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/job/JobTask.java:
##########
@@ -54,17 +55,35 @@ public class JobTask implements Writable {
     @SerializedName("errorMsg")
     private String errorMsg;
 
+    @SerializedName("taskType")
+    private TaskType taskType = TaskType.SCHEDULER_JOB_TASK;
+
+    /**
+     * Some parameters specific to the current task that need to be used to 
execute the task
+     * eg: sql task, sql it's: select * from table where id = 1 order by id 
desc limit ${limit} offset ${offset}
+     * contextData is a map, key1 is limit, value is 10,key2 is offset, value 
is 1
+     * when execute the task, we will replace the ${limit} to 10, ${offset} to 
1
+     * so to execute sql is: select * from table where id = 1 order by id desc 
limit 10 offset 1.
+     */
+    private T contextData;

Review Comment:
   Why not persist?



##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/job/JobTask.java:
##########
@@ -54,17 +55,35 @@ public class JobTask implements Writable {
     @SerializedName("errorMsg")
     private String errorMsg;
 
+    @SerializedName("taskType")
+    private TaskType taskType = TaskType.SCHEDULER_JOB_TASK;
+
+    /**
+     * Some parameters specific to the current task that need to be used to 
execute the task
+     * eg: sql task, sql it's: select * from table where id = 1 order by id 
desc limit ${limit} offset ${offset}
+     * contextData is a map, key1 is limit, value is 10,key2 is offset, value 
is 1
+     * when execute the task, we will replace the ${limit} to 10, ${offset} to 
1
+     * so to execute sql is: select * from table where id = 1 order by id desc 
limit 10 offset 1.
+     */
+    private T contextData;

Review Comment:
   Why not persist?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to