github-actions[bot] commented on code in PR #25946:
URL: https://github.com/apache/doris/pull/25946#discussion_r1375622119
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -63,17 +61,14 @@ Status
DataTypeDateTimeV2SerDe::serialize_one_cell_to_json(const IColumn& column
return Status::OK();
}
-Status DataTypeDateTimeV2SerDe::deserialize_column_from_json_vector(IColumn&
column,
-
std::vector<Slice>& slices,
- int*
num_deserialized,
- const
FormatOptions& options,
- int
nesting_level) const {
+Status DataTypeDateTimeV2SerDe::deserialize_column_from_json_vector(
Review Comment:
warning: method 'deserialize_column_from_json_vector' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeDateTimeV2SerDe::deserialize_column_from_json_vector(
```
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:65:
```diff
- const FormatOptions& options) const {
+ const FormatOptions& options) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
