englefly commented on code in PR #25800:
URL: https://github.com/apache/doris/pull/25800#discussion_r1375579630
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java:
##########
@@ -269,8 +271,13 @@ private LogicalPlan subqueryToApply(List<SubqueryExpr>
subqueryExprs, LogicalPla
private boolean nonMarkJoinExistsWithAgg(SubqueryExpr exists,
Map<SubqueryExpr, Optional<MarkJoinSlotReference>>
subqueryToMarkJoinSlot) {
return exists instanceof Exists
- && exists.getQueryPlan().anyMatch(Aggregate.class::isInstance)
- && !subqueryToMarkJoinSlot.get(exists).isPresent();
+ && exists.getQueryPlan()
Review Comment:
exists (select B from X group by B)
当X 是空集时 exists 是false
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java:
##########
@@ -269,8 +271,13 @@ private LogicalPlan subqueryToApply(List<SubqueryExpr>
subqueryExprs, LogicalPla
private boolean nonMarkJoinExistsWithAgg(SubqueryExpr exists,
Map<SubqueryExpr, Optional<MarkJoinSlotReference>>
subqueryToMarkJoinSlot) {
return exists instanceof Exists
- && exists.getQueryPlan().anyMatch(Aggregate.class::isInstance)
- && !subqueryToMarkJoinSlot.get(exists).isPresent();
+ && exists.getQueryPlan()
Review Comment:
exists (select B from X group by B)
当X 是空集时 exists 是false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
