github-actions[bot] commented on code in PR #25795:
URL: https://github.com/apache/doris/pull/25795#discussion_r1373023387
##########
be/src/service/internal_service.cpp:
##########
@@ -516,7 +515,11 @@ Status
PInternalServiceImpl::_exec_plan_fragment_impl(const std::string& ser_req
uint32_t len = ser_request.size();
RETURN_IF_ERROR(deserialize_thrift_msg(buf, &len, compact,
&t_request));
}
- return _exec_env->fragment_mgr()->exec_plan_fragment(t_request);
+ if (cb) {
+ return _exec_env->fragment_mgr()->exec_plan_fragment(t_request,
cb);
+ } else {
+ return _exec_env->fragment_mgr()->exec_plan_fragment(t_request);
+ }
Review Comment:
warning: do not use 'else' after 'return' [readability-else-after-return]
```suggestion
} return
_exec_env->fragment_mgr()->exec_plan_fragment(t_request);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
