github-actions[bot] commented on code in PR #25796:
URL: https://github.com/apache/doris/pull/25796#discussion_r1372094706


##########
be/src/olap/memtable_writer.cpp:
##########
@@ -274,41 +278,43 @@ Status MemTableWriter::_do_close_wait() {
     return Status::OK();
 }
 
-void MemTableWriter::_update_profile(RuntimeProfile* profile) {
+void MemTableWriter::_init_profile(RuntimeProfile* profile) {

Review Comment:
   warning: method '_init_profile' can be made static 
[readability-convert-member-functions-to-static]
   
   be/src/olap/memtable_writer.h:116:
   ```diff
   -     void _init_profile(RuntimeProfile* profile);
   +     static void _init_profile(RuntimeProfile* profile);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to