weizuo93 commented on a change in pull request #5158:
URL: https://github.com/apache/incubator-doris/pull/5158#discussion_r549615551
##########
File path: be/src/common/config.h
##########
@@ -256,21 +222,18 @@ CONF_Int32(file_descriptor_cache_capacity, "32768");
// modify them upon necessity
CONF_Int32(min_file_descriptor_number, "60000");
CONF_Int64(index_stream_cache_capacity, "10737418240");
-// CONF_Int64(max_packed_row_block_size, "20971520");
// Cache for storage page size
CONF_String(storage_page_cache_limit, "20%");
// whether to disable page cache feature in storage
-CONF_Bool(disable_storage_page_cache, "false");
+CONF_mBool(disable_storage_page_cache, "false");
Review comment:
The config `disable_storage_page_cache`is not used to close cache but to
choose whether to use the cache during read. So the memory used by cache will
not be freed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
