morrySnow commented on code in PR #25752:
URL: https://github.com/apache/doris/pull/25752#discussion_r1369651332
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -326,19 +327,7 @@ public Cost visitPhysicalHashJoin(
);
}
- private boolean isStatsUnknown(PhysicalHashJoin<? extends Plan, ? extends
Plan> join,
- Statistics build, Statistics probe) {
- for (Slot slot : join.getConditionSlot()) {
- if ((build.columnStatistics().containsKey(slot) &&
!build.columnStatistics().get(slot).isUnKnown)
- || (probe.columnStatistics().containsKey(slot) &&
!probe.columnStatistics().get(slot).isUnKnown)) {
- continue;
- }
- return true;
- }
- return false;
- }
-
- private boolean isStatsUnknown(PhysicalNestedLoopJoin<? extends Plan, ?
extends Plan> join,
+ private boolean isStatsUnknown(AbstractPhysicalJoin<? extends Plan, ?
extends Plan> join,
Review Comment:
move these refactors to another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
