zhannngchen commented on code in PR #25745:
URL: https://github.com/apache/doris/pull/25745#discussion_r1369448716
##########
be/src/olap/tablet.cpp:
##########
@@ -1785,7 +1785,7 @@ Status
Tablet::prepare_compaction_and_calculate_permits(CompactionType compactio
if (!res.ok()) {
set_last_base_compaction_failure_time(UnixMillis());
*permits = 0;
- if (!res.is<BE_NO_SUITABLE_VERSION>()) {
+ if (!res.is<BE_NO_SUITABLE_VERSION>() &&
!res.is<FULL_NO_SUITABLE_VERSION>()) {
Review Comment:
don't change here, this is error code for base compaction, and
`FULL_NO_SUITABLE_VERSION` is generated by full compaction.
##########
be/src/olap/tablet.cpp:
##########
@@ -1805,7 +1805,7 @@ Status
Tablet::prepare_compaction_and_calculate_permits(CompactionType compactio
if (!res.ok()) {
set_last_full_compaction_failure_time(UnixMillis());
*permits = 0;
- if (!res.is<BE_NO_SUITABLE_VERSION>()) {
+ if (!res.is<BE_NO_SUITABLE_VERSION>() &&
!res.is<FULL_NO_SUITABLE_VERSION>()) {
Review Comment:
```suggestion
if (!res.is<FULL_NO_SUITABLE_VERSION>()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
