github-actions[bot] commented on code in PR #25470:
URL: https://github.com/apache/doris/pull/25470#discussion_r1368481034
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -140,47 +143,37 @@ Status
DataTypeDateTimeV2SerDe::write_column_to_mysql(const IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
-Status DataTypeDateTimeV2SerDe::write_column_to_orc(const IColumn& column,
const NullMap* null_map,
+Status DataTypeDateTimeV2SerDe::write_column_to_orc(const std::string&
timezone,
Review Comment:
warning: method 'write_column_to_orc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeDateTimeV2SerDe::write_column_to_orc(const
std::string& timezone,
```
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:149:
```diff
-
std::vector<StringRef>& buffer_list) const {
+
std::vector<StringRef>& buffer_list) {
```
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -144,7 +144,8 @@ Status DataTypeDateV2SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
-Status DataTypeDateV2SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+Status DataTypeDateV2SerDe::write_column_to_orc(const std::string& timezone,
const IColumn& column,
Review Comment:
warning: method 'write_column_to_orc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeDateV2SerDe::write_column_to_orc(const std::string&
timezone, const IColumn& column,
```
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:150:
```diff
- std::vector<StringRef>&
buffer_list) const {
+ std::vector<StringRef>&
buffer_list) {
```
##########
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##########
@@ -115,7 +115,8 @@ void DataTypeJsonbSerDe::write_column_to_arrow(const
IColumn& column, const Null
}
}
-Status DataTypeJsonbSerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+Status DataTypeJsonbSerDe::write_column_to_orc(const std::string& timezone,
const IColumn& column,
Review Comment:
warning: method 'write_column_to_orc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeJsonbSerDe::write_column_to_orc(const std::string&
timezone, const IColumn& column,
```
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:120:
```diff
- int end,
std::vector<StringRef>& buffer_list) const {
+ int end,
std::vector<StringRef>& buffer_list) {
```
##########
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##########
@@ -274,7 +274,8 @@ Status DataTypeDate64SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
-Status DataTypeDate64SerDe::write_column_to_orc(const IColumn& column, const
NullMap* null_map,
+Status DataTypeDate64SerDe::write_column_to_orc(const std::string& timezone,
const IColumn& column,
Review Comment:
warning: method 'write_column_to_orc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeDate64SerDe::write_column_to_orc(const std::string&
timezone, const IColumn& column,
```
be/src/vec/data_types/serde/data_type_date64_serde.cpp:280:
```diff
- std::vector<StringRef>&
buffer_list) const {
+ std::vector<StringRef>&
buffer_list) {
```
##########
be/src/vec/data_types/serde/data_type_quantilestate_serde.h:
##########
@@ -121,8 +121,9 @@ class DataTypeQuantileStateSerDe : public DataTypeSerDe {
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
- Status write_column_to_orc(const IColumn& column, const NullMap* null_map,
- orc::ColumnVectorBatch* orc_col_batch, int
start, int end,
+ Status write_column_to_orc(const std::string& timezone, const IColumn&
column,
Review Comment:
warning: method 'write_column_to_orc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status write_column_to_orc(const std::string& timezone, const
IColumn& column,
```
be/src/vec/data_types/serde/data_type_quantilestate_serde.h:126:
```diff
- std::vector<StringRef>& buffer_list) const
override {
+ std::vector<StringRef>& buffer_list)
override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
