platoneko commented on code in PR #25691:
URL: https://github.com/apache/doris/pull/25691#discussion_r1368131765
##########
be/src/io/fs/file_writer.h:
##########
@@ -33,6 +33,7 @@ struct FileWriterOptions {
bool write_file_cache = false;
bool is_cold_data = false;
int64_t file_cache_expiration = 0; // Absolute time
+ bool sync_file_data = true; // weather flush data into storage
system
Review Comment:
```suggestion
bool sync_file_data = true; // Whether flush data into storage
system
```
另外比较建议把这个bool放到int64之前让struct内存布局更紧凑
##########
be/src/io/fs/file_writer.h:
##########
@@ -33,6 +33,7 @@ struct FileWriterOptions {
bool write_file_cache = false;
bool is_cold_data = false;
int64_t file_cache_expiration = 0; // Absolute time
+ bool sync_file_data = true; // weather flush data into storage
system
Review Comment:
```suggestion
bool sync_file_data = true; // Whether flush data into storage
system
```
另外比较建议把这个bool放到int64之前让struct内存布局更紧凑
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
