github-actions[bot] commented on code in PR #23894:
URL: https://github.com/apache/doris/pull/23894#discussion_r1368096326


##########
be/src/vec/exec/scan/vmeta_scanner.cpp:
##########
@@ -375,6 +378,26 @@ Status 
VMetaScanner::_build_catalogs_metadata_request(const TMetaScanRange& meta
     return Status::OK();
 }
 
+Status VMetaScanner::_build_materialized_views_metadata_request(const 
TMetaScanRange& meta_scan_range,

Review Comment:
   warning: method '_build_materialized_views_metadata_request' can be made 
static [readability-convert-member-functions-to-static]
   
   be/src/vec/exec/scan/vmeta_scanner.h:83:
   ```diff
   -     Status _build_materialized_views_metadata_request(const 
TMetaScanRange& meta_scan_range,
   +     static Status _build_materialized_views_metadata_request(const 
TMetaScanRange& meta_scan_range,
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to