github-actions[bot] commented on code in PR #25727:
URL: https://github.com/apache/doris/pull/25727#discussion_r1367923296
##########
be/src/vec/exec/vmysql_scan_node.cpp:
##########
@@ -231,7 +231,8 @@ void VMysqlScanNode::debug_string(int indentation_level,
std::stringstream* out)
}
}
-Status VMysqlScanNode::set_scan_ranges(const std::vector<TScanRangeParams>&
scan_ranges) {
+Status VMysqlScanNode::set_scan_ranges(RuntimeState* state,
Review Comment:
warning: method 'set_scan_ranges' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VMysqlScanNode::set_scan_ranges(RuntimeState* state,
```
##########
be/src/pipeline/exec/scan_operator.h:
##########
@@ -219,7 +220,8 @@ class ScanLocalState : public ScanLocalStateBase {
}
Status clone_conjunct_ctxs(vectorized::VExprContextSPtrs& conjuncts)
override;
- virtual void set_scan_ranges(const std::vector<TScanRangeParams>&
scan_ranges) override {}
+ virtual void set_scan_ranges(RuntimeState* state,
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
void set_scan_ranges(RuntimeState* state,
```
##########
be/src/vec/exec/vschema_scan_node.cpp:
##########
@@ -302,7 +302,8 @@ void VSchemaScanNode::debug_string(int indentation_level,
std::stringstream* out
}
}
-Status VSchemaScanNode::set_scan_ranges(const std::vector<TScanRangeParams>&
scan_ranges) {
+Status VSchemaScanNode::set_scan_ranges(RuntimeState* state,
Review Comment:
warning: method 'set_scan_ranges' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VSchemaScanNode::set_scan_ranges(RuntimeState* state,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
