Dam1029 commented on a change in pull request #5112:
URL: https://github.com/apache/incubator-doris/pull/5112#discussion_r548363576



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/proc/JvmProcDir.java
##########
@@ -94,6 +94,12 @@ public ProcResult fetchResult() throws AnalysisException {
         Threads threads = jvmStats.getThreads();
         result.addRow(genRow("threads count", threads.getCount()));
         result.addRow(genRow("threads peak count", threads.getPeakCount()));
+        result.addRow(genRow("threads new count", 
threads.getThreadsNewCount()));

Review comment:
       FE监控项: 
[http://doris.apache.org/master/zh-CN/administrator-guide/operation/monitor-metrics/fe-metrics.html#%E6%9F%A5%E7%9C%8B%E7%9B%91%E6%8E%A7%E9%A1%B9](url)
   
   Currently, the docs about metrics contains PrometheusMetrics and 
SystemMetrics.  The doris_fe_snmp belong to SystemMetrics, and the new metrics 
I added belong to PrometheusMetrics. I want to confirm did I need to add every 
new metrics in this page?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to