eldenmoon commented on code in PR #25669:
URL: https://github.com/apache/doris/pull/25669#discussion_r1366537304
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -422,7 +422,8 @@ void ColumnArray::reserve(size_t n) {
//please check you real need size in data column, because it's maybe need
greater size when data is string column
void ColumnArray::resize(size_t n) {
- get_offsets().resize(n);
+ auto last_off = get_offsets().back();
+ get_offsets().resize_fill(n, last_off);
get_data().resize(n);
Review Comment:
Is this `get_data().resize(n)` correct? for example if this array contains 3
element s`[1, 2]` `[1, 2]` `[1, 2]`, so the inner data size is 6 instead of 3.
so after doing `::resize(3)`, the inner data size became 3 and lost 3 nested
element.Is this semantic right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
