acelyc111 commented on a change in pull request #5113:
URL: https://github.com/apache/incubator-doris/pull/5113#discussion_r547080418
##########
File path: be/src/olap/olap_define.h
##########
@@ -189,11 +189,12 @@ enum OLAPStatus {
// StorageEngine
// [-500, -600)
OLAP_ERR_ENGINE_INSERT_EXISTS_TABLE = -500,
- OLAP_ERR_ENGINE_DROP_NOEXISTS_TABLE = -501,
- OLAP_ERR_ENGINE_LOAD_INDEX_TABLE_ERROR = -502,
- OLAP_ERR_TABLE_INSERT_DUPLICATION_ERROR = -503,
- OLAP_ERR_DELETE_VERSION_ERROR = -504,
- OLAP_ERR_GC_SCAN_PATH_ERROR = -505,
+ OLAP_ERR_ENGINE_INSERT_OLD_TABLET = -501,
Review comment:
Better to append the new code as -506 and not change the exist codes to
keep compatiable, assume some log analysis tool may depends on these code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
