github-actions[bot] commented on code in PR #25560:
URL: https://github.com/apache/doris/pull/25560#discussion_r1365005163
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -209,13 +215,14 @@ Status GroupCommitTable::_create_group_commit_load(
}
TStreamLoadPutResult result;
TNetworkAddress master_addr = _exec_env->master_info()->network_address;
- RETURN_IF_ERROR(ThriftRpcHelper::rpc<FrontendServiceClient>(
+ st = ThriftRpcHelper::rpc<FrontendServiceClient>(
master_addr.hostname, master_addr.port,
[&result, &request](FrontendServiceConnection& client) {
client->streamLoadPut(result, request);
},
- 10000L));
- Status st = Status::create(result.status);
+ 10000L);
Review Comment:
warning: 10000L is a magic number; consider replacing it with a named
constant [readability-magic-numbers]
```cpp
10000L);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
