github-actions[bot] commented on code in PR #25618:
URL: https://github.com/apache/doris/pull/25618#discussion_r1364905067
##########
be/src/vec/sink/load_stream_stub.h:
##########
@@ -85,17 +85,33 @@ class LoadStreamStub {
private:
class LoadStreamReplyHandler : public brpc::StreamInputHandler {
public:
- LoadStreamReplyHandler(LoadStreamStub* stub) : _stub(stub) {}
-
int on_received_messages(brpc::StreamId id, butil::IOBuf* const
messages[],
size_t size) override;
void on_idle_timeout(brpc::StreamId id) override {}
void on_closed(brpc::StreamId id) override;
+ bool is_closed() { return _is_closed.load(); }
+
+ Status close_wait(int64_t timeout_ms) {
Review Comment:
warning: method 'close_wait' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status close_wait(int64_t timeout_ms) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
