JackDrogon commented on code in PR #25578:
URL: https://github.com/apache/doris/pull/25578#discussion_r1363859753
##########
be/src/olap/rowset/vertical_beta_rowset_writer.cpp:
##########
@@ -56,8 +55,7 @@ VerticalBetaRowsetWriter::~VerticalBetaRowsetWriter() {
// Even if an error is encountered, these files that have not been
cleaned up
// will be cleaned up by the GC background. So here we only print
the error
// message when we encounter an error.
- WARN_IF_ERROR(fs->delete_file(path),
- strings::Substitute("Failed to delete file=$0",
path));
+ WARN_IF_ERROR(fs->delete_file(path), fmt::format("Failed to delete
file={}", path));
Review Comment:
add `#include <fmt/format.h>`
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -94,7 +93,7 @@ BetaRowsetWriter::~BetaRowsetWriter() {
// will be cleaned up by the GC background. So here we only print
the error
// message when we encounter an error.
WARN_IF_ERROR(fs->delete_file(seg_path),
- strings::Substitute("Failed to delete file=$0",
seg_path));
+ fmt::format("Failed to delete file={}", seg_path));
Review Comment:
add `#include <fmt/format.h>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
