wuyunfeng commented on a change in pull request #4690:
URL: https://github.com/apache/incubator-doris/pull/4690#discussion_r544999570



##########
File path: docs/zh-CN/sql-reference/sql-statements/Data Manipulation/BROKER 
LOAD.md
##########
@@ -477,6 +485,21 @@ under the License.
          ORDER BY source_sequence
         ) 
         with BROKER "hdfs" ("username"="user", "password"="pass");
+
+    15. 从 Aliyun OSS 导入csv格式的数据
+        LOAD LABEL example_db.label15
+        (
+        DATA INFILE("oss://my_bucket/input/file.csv")
+        INTO TABLE `my_table`
+        (k1, k2, k3)
+        )
+        WITH BROKER my_oss_broker
+        (
+        "fs.oss.accessKeyId" = "xxxxxxxxxxxxxxxxxxxxxxxxxx",

Review comment:
       ```suggestion
           "fs.oss.accessKey" = "xxxxxxxxxxxxxxxxxxxxxxxxxx",
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java
##########
@@ -227,8 +227,8 @@ private static void checkPath(String path) throws 
AnalysisException {
             URI uri = new URI(path);
             String schema = uri.getScheme();
             if (schema == null || (!schema.equalsIgnoreCase("bos") && 
!schema.equalsIgnoreCase("afs")
-                    && !schema.equalsIgnoreCase("hdfs"))) {
-                throw new AnalysisException("Invalid export path. please use 
valid 'HDFS://', 'AFS://' or 'BOS://' path.");
+                    && !schema.equalsIgnoreCase("hdfs") && 
!schema.equalsIgnoreCase("oss"))) {

Review comment:
       If many `fs` or `object storage`, we can use a `enmu` to judge this

##########
File path: docs/zh-CN/sql-reference/sql-statements/Data Manipulation/BROKER 
LOAD.md
##########
@@ -477,6 +485,21 @@ under the License.
          ORDER BY source_sequence
         ) 
         with BROKER "hdfs" ("username"="user", "password"="pass");
+
+    15. 从 Aliyun OSS 导入csv格式的数据
+        LOAD LABEL example_db.label15
+        (
+        DATA INFILE("oss://my_bucket/input/file.csv")
+        INTO TABLE `my_table`
+        (k1, k2, k3)
+        )
+        WITH BROKER my_oss_broker
+        (
+        "fs.oss.accessKeyId" = "xxxxxxxxxxxxxxxxxxxxxxxxxx",
+        "fs.oss.accessKeySecret" = "yyyyyyyyyyyyyyyyyyyy",

Review comment:
       ```suggestion
           "fs.oss.secretKey" = "yyyyyyyyyyyyyyyyyyyy",
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to