starocean999 commented on code in PR #24965: URL: https://github.com/apache/doris/pull/24965#discussion_r1363041548
########## regression-test/suites/datatype_p0/ip/test_ip_crud.groovy: ########## @@ -0,0 +1,105 @@ + +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_ip_crud") { + sql """ DROP TABLE IF EXISTS test_unique_ip_crud """ + sql """ DROP TABLE IF EXISTS test_dup_ip_crud """ + + sql """ SET enable_nereids_planner=true """ + sql """ SET enable_fallback_to_original_planner=false """ + + sql """ + CREATE TABLE test_unique_ip_crud ( Review Comment: for dml statement, even 'SET enable_fallback_to_original_planner=false', the nereids will fallback to old planner if meets any error. So to support ipv4 and ipv6 keyword in nereids, we need modiy the g4 grammer files: src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4 src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 and check visitCreateTable in org/apache/doris/nereids/parser/LogicalPlanBuilder.java works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
