eldenmoon commented on code in PR #24603:
URL: https://github.com/apache/doris/pull/24603#discussion_r1363022121


##########
be/src/util/arrow/block_convertor.cpp:
##########
@@ -408,7 +410,10 @@ Status 
FromBlockConverter::convert(std::shared_ptr<arrow::RecordBatch>* out) {
 Status convert_to_arrow_batch(const vectorized::Block& block,
                               const std::shared_ptr<arrow::Schema>& schema, 
arrow::MemoryPool* pool,
                               std::shared_ptr<arrow::RecordBatch>* result) {
-    FromBlockConverter converter(block, schema, pool);
+    // FromBlockConverter converter(block, schema, pool);
+    std::shared_ptr<arrow::Schema> block_arrow_schema;
+    RETURN_IF_ERROR(get_block_arrow_schema(block, &block_arrow_schema));

Review Comment:
   after expr, schema may be changed. For example after a cast expr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to