BePPPower commented on code in PR #25395:
URL: https://github.com/apache/doris/pull/25395#discussion_r1361610056
##########
fe/fe-core/src/main/java/org/apache/doris/common/FeNameFormat.java:
##########
@@ -138,6 +140,12 @@ public static void checkCommonName(String type, String
name) throws AnalysisExce
}
}
+ public static void checkSuccessFileName(String type, String name) throws
AnalysisException {
Review Comment:
```suggestion
public static void checkOutfileSuccessFileName(String type, String name)
throws AnalysisException {
```
May it is better to call this method as `checkOutfileSuccessFileName`
##########
fe/fe-core/src/test/java/org/apache/doris/common/FeNameFormatTest.java:
##########
@@ -55,6 +55,9 @@ public void testCheckColumnName() {
ExceptionChecker.expectThrows(AnalysisException.class, () ->
FeNameFormat.checkCommonName("fakeType", "_commonName"));
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkCommonName("fakeType", "common-Name"));
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkCommonName("fakeType", "commonName-"));
+
+ // check success file name prefix
+ ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkColumnName("_success"));
Review Comment:
```suggestion
// check success file name prefix
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkSuccessFileName("_success"));
```
Is this wrong here?It should be `checkSuccessFileName`？
##########
fe/fe-core/src/test/java/org/apache/doris/common/FeNameFormatTest.java:
##########
@@ -55,6 +55,9 @@ public void testCheckColumnName() {
ExceptionChecker.expectThrows(AnalysisException.class, () ->
FeNameFormat.checkCommonName("fakeType", "_commonName"));
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkCommonName("fakeType", "common-Name"));
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkCommonName("fakeType", "commonName-"));
+
+ // check success file name prefix
+ ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkColumnName("_success"));
Review Comment:
```suggestion
// check success file name prefix
ExceptionChecker.expectThrowsNoException(() ->
FeNameFormat.checkSuccessFileName("_success"));
```
Is this wrong here?It should be `checkSuccessFileName`？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
