englefly commented on code in PR #25471:
URL: https://github.com/apache/doris/pull/25471#discussion_r1361421357
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateTableCommand.java:
##########
@@ -109,7 +109,7 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
dataType =
VarcharType.createVarcharType(ScalarType.MAX_VARCHAR_LENGTH);
} else if (dataType instanceof CharacterType) {
// if column is not come from column, we should set varchar
length to max
Review Comment:
"if column is not come from column“ 顺便改一下吧 ”if column is not come from
table,“
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateTableCommand.java:
##########
@@ -109,7 +109,7 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
dataType =
VarcharType.createVarcharType(ScalarType.MAX_VARCHAR_LENGTH);
} else if (dataType instanceof CharacterType) {
// if column is not come from column, we should set varchar
length to max
- if (((CharacterType) dataType).getLen() > 0 &&
!s.isColumnFromTable()) {
Review Comment:
if this column is varchar(10), why set the length to 65533?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateTableCommand.java:
##########
@@ -109,7 +109,7 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
dataType =
VarcharType.createVarcharType(ScalarType.MAX_VARCHAR_LENGTH);
} else if (dataType instanceof CharacterType) {
// if column is not come from column, we should set varchar
length to max
Review Comment:
"if column is not come from column“ 顺便改一下吧 ”if column is not come from
table,“
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
