github-actions[bot] commented on code in PR #25448:
URL: https://github.com/apache/doris/pull/25448#discussion_r1360177152
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -19,6 +19,7 @@
#include <sqltypes.h>
Review Comment:
warning: 'sqltypes.h' file not found [clang-diagnostic-error]
```cpp
#include <sqltypes.h>
^
```
##########
be/src/pipeline/exec/union_source_operator.cpp:
##########
@@ -124,9 +134,10 @@ Status UnionSourceLocalState::init(RuntimeState* state,
LocalStateInfo& info) {
return Status::OK();
}
-std::shared_ptr<DataQueue> UnionSourceLocalState::create_data_queue() {
+std::shared_ptr<UnionSharedState> UnionSourceLocalState::create_shared_state()
{
Review Comment:
warning: method 'create_shared_state' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/union_source_operator.h:81:
```diff
- std::shared_ptr<UnionSharedState> create_shared_state();
+ static std::shared_ptr<UnionSharedState> create_shared_state();
```
##########
be/src/pipeline/exec/multi_cast_data_stream_sink.h:
##########
@@ -93,9 +94,9 @@ class MultiCastDataStreamSinkOperatorX final
RowDescriptor& row_desc() override { return _row_desc; }
- std::shared_ptr<pipeline::MultiCastDataStreamer>
create_multi_cast_data_streamer() {
- auto multi_cast_data_streamer =
std::make_shared<pipeline::MultiCastDataStreamer>(
- _row_desc, _pool, _cast_sender_count);
+ std::shared_ptr<MultiCastSharedState> create_multi_cast_data_streamer() {
Review Comment:
warning: method 'create_multi_cast_data_streamer' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<MultiCastSharedState>
create_multi_cast_data_streamer() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
