platoneko commented on code in PR #24364:
URL: https://github.com/apache/doris/pull/24364#discussion_r1357149004
##########
be/src/io/io_common.h:
##########
@@ -52,8 +52,10 @@ struct IOContext {
// FIXME(plat1ko): Seems `is_disposable` can be inferred from the
`reader_type`?
bool is_disposable = false;
bool is_index_data = false;
- bool read_file_cache = true;
+ // TODO(lightman): use following member variables to control file cache
+ bool is_persistent = false;
int64_t expiration_time = 0;
Review Comment:
别改顺序，节省点struct size
##########
be/src/io/io_common.h:
##########
@@ -52,8 +52,10 @@ struct IOContext {
// FIXME(plat1ko): Seems `is_disposable` can be inferred from the
`reader_type`?
bool is_disposable = false;
bool is_index_data = false;
- bool read_file_cache = true;
+ // TODO(lightman): use following member variables to control file cache
+ bool is_persistent = false;
int64_t expiration_time = 0;
Review Comment:
别改顺序，节省点struct size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
