xinyiZzz commented on code in PR #23385:
URL: https://github.com/apache/doris/pull/23385#discussion_r1356404432
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -257,7 +261,10 @@ std::string MemTrackerLimiter::log_process_usage_str() {
detail += "\nProcess Memory Summary:\n " +
MemTrackerLimiter::process_mem_log_str();
std::vector<MemTracker::Snapshot> snapshots;
MemTrackerLimiter::make_process_snapshots(&snapshots);
- MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::GLOBAL);
+ MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::GLOBAL, false);
+ MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::COMPACTION, false);
+ MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::QUERY, false);
+ MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::LOAD, false);
Review Comment:
`QUERY` and `LOAD` do not make snapshots, `GLOBAL` should be with_child=true
`COMPACTION` tasks may be very many?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
