github-actions[bot] commented on code in PR #24229:
URL: https://github.com/apache/doris/pull/24229#discussion_r1354872557
##########
be/src/olap/storage_engine.cpp:
##########
@@ -360,6 +362,24 @@ Status
StorageEngine::get_all_data_dir_info(std::vector<DataDirInfo>* data_dir_i
return res;
}
+void StorageEngine::get_special_dir_info(SpecialDirInfo* special_dir_infos,
TDiskType::type type) {
+ switch (type) {
+ case TDiskType::LOG:
+ _log_dir->health_check();
+ static_cast<void>(_log_dir->update_capacity());
+ _log_dir->get_dir_info(special_dir_infos);
+ break;
+ case TDiskType::DEPLOY:
+ _deploy_dir->health_check();
+ static_cast<void>(_deploy_dir->update_capacity());
+ _deploy_dir->get_dir_info(special_dir_infos);
+ break;
+ default:
+ break;
+ }
+ return;
+}
+
Review Comment:
warning: redundant return statement at the end of a function with a void
return type [readability-redundant-control-flow]
```suggestion
}
```
##########
be/src/agent/task_worker_pool.h:
##########
@@ -19,6 +19,7 @@
#include <butil/macros.h>
Review Comment:
warning: 'butil/macros.h' file not found [clang-diagnostic-error]
```cpp
#include <butil/macros.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
